Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for updates in starter #203

Merged
merged 1 commit into from Aug 5, 2021
Merged

feat: check for updates in starter #203

merged 1 commit into from Aug 5, 2021

Conversation

ankithans
Copy link
Member

@ankithans ankithans commented Aug 5, 2021

Closes #138

Description

confusion in (devel); while doing

if info, ok := debug.ReadBuildInfo(); ok {
	fmt.Println(info.Main.Version) // it prints (devel)
}

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@ankithans ankithans requested a review from a team August 5, 2021 10:25
@wtrocki
Copy link
Contributor

wtrocki commented Aug 5, 2021

Why we are doing this particular problem?

@ankithans
Copy link
Member Author

ankithans commented Aug 5, 2021

This is to prompt the user, if any update is available.

eg.
Screenshot 2021-08-05 at 5 02 38 PM

@wtrocki
Copy link
Contributor

wtrocki commented Aug 5, 2021

I get that - but why this is priority :D

@wtrocki
Copy link
Contributor

wtrocki commented Aug 5, 2021

Anyway.. let's get that over since it is done and move to more interesting things

@wtrocki wtrocki merged commit e25d589 into main Aug 5, 2021
@wtrocki wtrocki deleted the check-updates branch August 5, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for updates feature that uses github releases
2 participants