New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor core package #219
Conversation
docs/src/charmil_factory.md
Outdated
// Loads config values from the local config file | ||
err := h.Load() | ||
if err != nil { | ||
log.Fatal(err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Loads config values from the local config file | |
err := h.Load() | |
if err != nil { | |
log.Fatal(err) | |
} |
This part can be removed as it's independent and has nothing to do with the factory initialization.
@ankithans I believe now you'll be making similar changes in the |
yes after release... |
No changes to charmil starter please. Let's build a script that will do something like this:
later we can do automation from releases - and do not update starter before release as well |
Do you mind publishing website (manually for now) |
done |
Closes #213
Closes #183
Closes #115
Description
Type of change
Checklist