Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor core package #219

Merged
merged 5 commits into from Aug 10, 2021
Merged

chore: refactor core package #219

merged 5 commits into from Aug 10, 2021

Conversation

ankithans
Copy link
Member

@ankithans ankithans commented Aug 10, 2021

Closes #213
Closes #183
Closes #115

Description

  • refactor core structure into folders
  • move factory from internal -> pkg
  • remove charmil commands docs(outdated)
  • update factory, i18n docs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@ankithans ankithans added documentation Improvements or additions to documentation enhancement New feature or request requires-release labels Aug 10, 2021
@ankithans ankithans requested a review from a team August 10, 2021 10:06
@ankithans ankithans self-assigned this Aug 10, 2021
@ankithans ankithans changed the title Core refactor chore: refactor core package Aug 10, 2021
Comment on lines 26 to 30
// Loads config values from the local config file
err := h.Load()
if err != nil {
log.Fatal(err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Loads config values from the local config file
err := h.Load()
if err != nil {
log.Fatal(err)
}

This part can be removed as it's independent and has nothing to do with the factory initialization.

@namit-chandwani
Copy link
Member

@ankithans I believe now you'll be making similar changes in the charmil-starter repo too

@ankithans
Copy link
Member Author

yes after release...

@wtrocki
Copy link
Contributor

wtrocki commented Aug 10, 2021

I believe now you'll be making similar changes in the charmil-starter repo too

No changes to charmil starter please. Let's build a script that will do something like this:

mkdir newrepo
cd newrepo
git init 
git remote add starter ...
cp -Rf ../starter ./
git commit -a -m"Starter update"
git push origin main

later we can do automation from releases - and do not update starter before release as well

@wtrocki
Copy link
Contributor

wtrocki commented Aug 10, 2021

Do you mind publishing website (manually for now)

@ankithans
Copy link
Member Author

done

@ankithans ankithans merged commit 8363053 into main Aug 10, 2021
@ankithans ankithans deleted the core-refactor branch August 10, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request requires-release
Projects
None yet
3 participants