-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify init command to not use placeholders #243
Conversation
This PR is now ready for review :) CC: @wtrocki |
ETA 1 day. Weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff but left some suggestions
I do not think all uses of cli name were properly replaced :) |
Sorry, missed the notification somehow. |
Merging this PR now and making a new Charmil release for both |
Closes #239
Description
The
init
command of Charmil CLI uses the template files and their placeholders that are currently present in thecharmil-starter
repo to generate a starter project, which makes thecharmil-starter
repo unusable without the init command (ie. users cannot clone the repo and use it directly due to the presence of template files).Our aim is to provide an additional option for users to use Charmil Starter by allowing them to directly clone the charmil-starter Github repository.
This can be achieved by following these 2 steps:
Change the init command implementation to replace default values with the user-specified ones (ie. Github org/user name, repo name and CLI name) by performing simple String replacements instead of using go templates and substituting its placeholders.
[Handled by this PR]
Remove the current contents of the charmil-starter repo (as it contains template files instead of runnable code) and replace it with the contents of the starter present in this repo (charmil/starter).
[Handled by the PR: chore: replace current repo contents with charmil/starter charmil-starter#7]
Type of change
Checklist