fix: traverse all the child cmds + duplicates #97
Conversation
|
https://github.com/aerogear/charmil/blob/ankithans/issue95/validator/example/cmd.go Here only cmd, cmd1, cmd2 are traversed. cmd3 is skipped! Checked with rhoas similar issue is persisting. Fixed the duplicate validation error. Trying to solve this issue |
ankithans
added
enhancement
validator/rules/executor.go
Outdated
| mustExistErrs := validateMustExist(cmd, config.MustExist, config.Verbose) | ||
| info.TotalErrors += len(mustExistErrs) | ||
|
|
||
| info.Errors = append(info.Errors, lenErrs...) |
There was a problem hiding this comment.
we should create method that does validate and add errorz for generic rule
| continue | ||
| } | ||
|
|
||
| // recursive call |
validator/rules/executor.go
Outdated
|
|
||
| // prints additional info in debug mode | ||
| if config.Verbose { | ||
| fmt.Printf("commands checked: %d\nchecks failed: %d\n", info.TotalTested, info.TotalErrors) |
There was a problem hiding this comment.
This is not verbose. It should be printed normally but to stderr
|
This was hard to debug, but got the desired output. Basically, It was a recursion problem 😄. issue #95 resolved $ go test ./validator/example/
--- FAIL: Test_ExecuteCommand (0.00s)
cmd_test.go:20: LENGTH_RULE: cmd cmd0: Long length should be at least 100
cmd_test.go:20: LENGTH_RULE: cmd cmd0: Example length should be at least 100
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd01 subcmd12: Short length should be at least 15
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd01 subcmd12: Long length should be at least 100
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd01 subcmd12: Example length should be at least 100
cmd_test.go:20: MUST_EXIST_RULE: cmd cmd0 subcmd01 subcmd12: Short must be present
cmd_test.go:20: MUST_EXIST_RULE: cmd cmd0 subcmd01 subcmd12: Long must be present
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd01: Short length should be at least 15
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd01: Long length should be at least 100
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd01: Example length should be at least 100
cmd_test.go:20: MUST_EXIST_RULE: cmd cmd0 subcmd01: Short must be present
cmd_test.go:20: MUST_EXIST_RULE: cmd cmd0 subcmd01: Long must be present
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd03: Short length should be at least 15
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd03: Long length should be at least 100
cmd_test.go:20: LENGTH_RULE: cmd cmd0 subcmd03: Example length should be at least 100
cmd_test.go:20: MUST_EXIST_RULE: cmd cmd0 subcmd03: Short must be present
cmd_test.go:20: MUST_EXIST_RULE: cmd cmd0 subcmd03: Long must be present
FAIL
FAIL github.com/aerogear/charmil/validator/example 0.152s
FAIL |
ankithans
changed the title
validator/example/cmd.go
Outdated
| @@ -17,21 +17,29 @@ func NewCommand() *cobra.Command { | |||
| } | |||
|
|
|||
| cmd1 := &cobra.Command{ | |||
| Use: "subcmd", | |||
| Use: "subcmd01", | |||
There was a problem hiding this comment.
Do you mind to use for loops for creating commands.
It will look better without DRY
validator/rules/executor.go
Outdated
| } | ||
|
|
||
| // prints additional info in debug mode | ||
| if config.Verbose { |
There was a problem hiding this comment.
Lets remove verbose check and use sdterr (
validator/rules/executor.go
Outdated
| func (config *RuleConfig) validate(cmd *cobra.Command, info *validator.StatusLog) { | ||
|
|
||
| // Length rule | ||
| lenErrs := validateLength(cmd, config.Length, config.Verbose) |
There was a problem hiding this comment.
Lets use for loop for processing rules rather than calling each rule
There was a problem hiding this comment.
@wtrocki I have addressed above 2 comments. As all rules gives different function to execute, how can I use them in loop?
like length - validateLength
MustExist - validateMustExist
And rule config also looks like this
type RuleConfig struct {
Verbose bool
Length
MustExist
}Can you suggest some way?
ankithans
force-pushed
the
ankithans/issue95
branch
from
26f5786
to
cc22a6e
Compare
|
lets release.
we should have the same interface and can the same function. Without that there will be no way to add rule to validator. Create issue for this. This two methods should be the same method |
Closes #95
Description
Fixes duplicate errors and traverse all the subcommands
Type of change
Checklist
Screenshots (if appropriate):