Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

fix: edited general styling #105

Merged
merged 8 commits into from
Mar 12, 2019
Merged

Conversation

milenazuccarelli
Copy link
Contributor

Description

Image for guidance as to how change should display is attached after each list item

Home page

  • Logo dimensions can be smaller
  • Links could appear in same order as menu items
  • Call to action on home page could be useful
    localhost_8100_ (1)

Manage Tasks page

  • Task item last-child could do without the border-bottom
  • Make border-bottom of each task item symmetrical
    tasks
  • "Number of items added when offline" and "Network status" badges could display inline with labels
    badges

Files

  • Remove extra padding on this page
  • Make border-bottom of uploaded file items symmetrical
    files

Settings page

  • Change heading title to make more consistent with other pages
    settings_header

About page

  • More information could also appear on a card
    more_information

Global

  • Border on menu items not full width
    menu_item

@milenazuccarelli milenazuccarelli changed the title Aerogear 8771 fix: edited general styling Mar 12, 2019
@wtrocki
Copy link
Contributor

wtrocki commented Mar 12, 2019

Just seen that change. Feel free to assign @wtrocki or @StephenCoady to any PRs

Copy link
Contributor

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified using local web view with different device sizes!
Great job!

@wtrocki wtrocki merged commit 6676e9b into aerogear:master Mar 12, 2019
@StephenCoady
Copy link
Member

Also didn't see this, ping either of us on anything. But well done - looks a lot better!

@milenazuccarelli milenazuccarelli deleted the AEROGEAR-8771 branch April 4, 2019 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants