Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly #2034

Merged
merged 4 commits into from Sep 14, 2020

Conversation

craicoverflow
Copy link

@craicoverflow craicoverflow commented Sep 11, 2020

This PR completely rewrites the Knex query builder, which was only ever intended as a prototype version originally and was very hard to maintain.

Tasks

@craicoverflow craicoverflow force-pushed the fix/2009 branch 5 times, most recently from 7347104 to b0d39b6 Compare Sep 11, 2020
@craicoverflow craicoverflow linked an issue Sep 14, 2020 that may be closed by this pull request
@craicoverflow craicoverflow force-pushed the fix/2009 branch 2 times, most recently from b7652fe to b9e36b9 Compare Sep 14, 2020
@craicoverflow craicoverflow changed the title [WIP] refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly Sep 14, 2020
@craicoverflow craicoverflow marked this pull request as ready for review Sep 14, 2020
@craicoverflow craicoverflow requested review from wtrocki and machi1990 Sep 14, 2020
@craicoverflow craicoverflow force-pushed the fix/2009 branch 2 times, most recently from f3ce7de to c0d25d5 Compare Sep 14, 2020
@wtrocki
Copy link
Member

wtrocki commented Sep 14, 2020

Verifying

Copy link
Contributor

@machi1990 machi1990 left a comment

Finished my first round of review and verification. I added a couple of comments as I was getting along the way.

I also think we should have a section in our documentation where we explain the semantics of the filters using pseudo code as the one used in this #2034 (comment)

docs/releases.md Outdated Show resolved Hide resolved
@craicoverflow craicoverflow requested a review from machi1990 Sep 14, 2020
Copy link
Contributor

@machi1990 machi1990 left a comment

All my comments have been addressed. Thanks Enda for a huge followup PR.

/cc @wtrocki you might want to have a look too.

@craicoverflow craicoverflow merged commit 3e08a22 into master Sep 14, 2020
@craicoverflow craicoverflow deleted the fix/2009 branch Sep 14, 2020
@craicoverflow craicoverflow added bug Something isn't working internal breaking and removed internal labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantics of how the or operator should be used
3 participants