Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly #2034

Merged
merged 4 commits into from
Sep 14, 2020
Merged

refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly #2034

merged 4 commits into from
Sep 14, 2020

Conversation

craicoverflow
Copy link

@craicoverflow craicoverflow commented Sep 11, 2020 •
edited
Loading

This PR completely rewrites the Knex query builder, which was only ever intended as a prototype version originally and was very hard to maintain.

Tasks

@craicoverflow craicoverflow linked an issue Sep 14, 2020 that may be closed by this pull request
Semantics of how the or operator should be used #2009
Closed
@craicoverflow craicoverflow changed the title [WIP] refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly refactor(knex): refactor knex query builder and fixes an issue where or queries were not mapped correctly Sep 14, 2020
@craicoverflow craicoverflow marked this pull request as ready for review September 14, 2020 09:36
@wtrocki
Copy link
Contributor

wtrocki commented Sep 14, 2020

Verifying

machi1990
machi1990 reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished my first round of review and verification. I added a couple of comments as I was getting along the way.

I also think we should have a section in our documentation where we explain the semantics of the filters using pseudo code as the one used in this #2034 (comment)

machi1990
machi1990 reviewed Sep 14, 2020
View reviewed changes
docs/releases.md Outdated Show resolved Hide resolved
machi1990
machi1990 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments have been addressed. Thanks Enda for a huge followup PR.

/cc @wtrocki you might want to have a look too.

@craicoverflow craicoverflow merged commit 3e08a22 into master Sep 14, 2020
@craicoverflow craicoverflow deleted the fix/2009 branch September 14, 2020 13:41
@craicoverflow craicoverflow added bug Something isn't working internal breaking and removed internal labels Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@wtrocki wtrocki Awaiting requested review from wtrocki

Assignees
No one assigned
Labels
breaking bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantics of how the or operator should be used
3 participants
@craicoverflow @wtrocki @machi1990