This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
fix: use grantManager to parse token in onSubscriptionConnect #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darahayes
force-pushed
the
createGrant
branch
2 times, most recently
from
c888153
to
d095a90
Compare
|
fixes #13 |
darahayes
changed the title
|
Originally, the PR had some changes that were breaking but I've managed to reduce it down so we get what we need but there are no breaking changes. |
wtrocki
reviewed
Jan 6, 2020
src/KeycloakSubscriptionHandler.ts
Outdated
| return new Token(token, clientId) | ||
| const tokenString = header.substring(7) | ||
| return { | ||
| access_token: tokenString |
There was a problem hiding this comment.
[Trivial] FieldName is not conforming to standards.
There was a problem hiding this comment.
Yeah so this is the format required by the keycloak.grantmanager.createGrant perhaps it would be better to return just the tokenString value here and then explicitly pass {access_token: tokenString} into that method call to make things clearer.
wtrocki
approved these changes
Jan 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.