Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize job name for multiple KeyCloak clusters on the same Prometheus PushGateway #102

Merged
merged 2 commits into from
May 17, 2021

Conversation

guerricmerleHUG
Copy link
Contributor

Motivation

#100

What

This Pull Request introduces a new system environnment variable PROMETHEUS_GROUPING_KEY_JOB to override default "keycloak" job name.

Why

Being able to define our own custom PROMETHEUS_GROUPING_KEY_JOB in order to separate indicators of different clusters

How

Add new system env PROMETHEUS_GROUPING_KEY_JOB

Verification Steps

Add the steps required to check this change. Following an example.

  1. Build the code
  2. Copy the artifact into $KC/standalone/deployments
  3. set system var env to PROMETHEUS_GROUPING_KEY_JOB=keycloak_cluster_A
  4. Make sure the metrics logger is turned on
  5. Play with Keycloak a bit
  6. Look at the following url: "$KC/auth/realms/master/metrics", job name is equals to keycloak_cluster_A

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task
  • TODO

Customize job name for multiple KeyCloak clusters on the same Prometheus PushGateway
@semangard
Copy link

@pb82 : is-it possible to check this PR please ?

@pb82
Copy link
Contributor

pb82 commented Apr 30, 2021

Yep, seems like a small enough change. I'll try to get it in asap.

@pb82 pb82 merged commit 5d145a2 into aerogear:master May 17, 2021
@semangard semangard mentioned this pull request Oct 26, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants