Add counter metrics for client_login, refresh_token and code_to_token #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To improve Keycloak observability @ Cdiscount (e-commerce platform), we need to add new gauge metrics with
client_id
anderror
informations.This PR will also close the issue #59
What
Adding new gauge metrics :
keycloak_client_logins
keycloak_failed_client_login_attempts
keycloak_refresh_tokens
keycloak_refresh_tokens_errors
keycloak_code_to_tokens
keycloak_code_to_tokens_errors
Why
We need to have the
client_id
anderror
informations for theses metrics.How
I added theses metrics based on the events :
CLIENT_LOGIN
CLIENT_LOGIN_ERROR
REFRESH_TOKEN
REFRESH_TOKEN_ERROR
CODE_TO_TOKEN
CODE_TO_TOKEN_ERROR
Verification Steps
Checklist:
Progress
Additional Notes
NA