Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

WIP - Create the Builds information #37

Merged
merged 3 commits into from
Aug 8, 2018
Merged

WIP - Create the Builds information #37

merged 3 commits into from
Aug 8, 2018

Conversation

ciaranRoche
Copy link
Member

Motivation

JIRA - https://issues.jboss.org/browse/AEROGEAR-7711

Todo

Still left to do, add pipeline status component

@coveralls
Copy link

coveralls commented Aug 3, 2018

Pull Request Test Coverage Report for Build 370

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.492%

Totals Coverage Status
Change from base Build 353: 0.0%
Covered Lines: 215
Relevant Lines: 305

💛 - Coveralls

@wei-lee
Copy link
Contributor

wei-lee commented Aug 7, 2018

@ciaranRoche is this PR ready to merge, or is this still WIP?

@ciaranRoche
Copy link
Member Author

@wei-lee There is still the pipeline stages to be added and maybe some additional styling. There is a bit of work over all in adding the pipeline stages, bringing Jan's PR components into the build view as well as removing any hard coding/mock data from the components and getting it all talking to the backend. If you want I can sync up with anyone looking for tasks in the morning and we can break out what is left of the build view into smaller tasks to get it done quicker.

@wei-lee
Copy link
Contributor

wei-lee commented Aug 7, 2018

@ciaranRoche ok. In that case, can you please create the subtasks in JIRA and make sure visible in the sprint, so that other are aware of the work left.

Also for this PR, if it's in good shape, maybe just merge it anyway (provided it will not break anything), and the rest of can be merged in separate PRs.

WDYT?

@ciaranRoche
Copy link
Member Author

@wei-lee Sounds good, once #38 gets merged, I can rebase off that, Ill sync with @jhellar then in the morning and we can task it out.

@jhellar jhellar self-requested a review August 8, 2018 11:15
Copy link
Contributor

@jhellar jhellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ciaranRoche ciaranRoche merged commit a015a71 into master Aug 8, 2018
@grdryn grdryn deleted the AEROGEAR-7711 branch January 7, 2019 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants