Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

Aerogear 7734 #38

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Aerogear 7734 #38

merged 2 commits into from
Aug 8, 2018

Conversation

jhellar
Copy link
Contributor

@jhellar jhellar commented Aug 6, 2018

@coveralls
Copy link

coveralls commented Aug 7, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 351

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.492%
Totals Coverage Status
Change from base Build 342: 0.0%
Covered Lines: 215
Relevant Lines: 305
💛 - Coveralls

ciaranRoche
ciaranRoche approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran these components locally, LGTM 👍

@wei-lee
Copy link
Contributor

wei-lee commented Aug 7, 2018

@jhellar can we merge this now?

@ciaranRoche ciaranRoche mentioned this pull request Aug 7, 2018
Merged
@jhellar
Copy link
Contributor Author

jhellar commented Aug 8, 2018

Rebased, merging.

@jhellar jhellar merged commit 85f7160 into master Aug 8, 2018
@grdryn grdryn deleted the AEROGEAR-7734 branch January 7, 2019 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ciaranRoche ciaranRoche ciaranRoche approved these changes

@sedroche sedroche Awaiting requested review from sedroche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhellar @coveralls @wei-lee @ciaranRoche