AEROGEAR-9674 add view permission for project and routes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Installer PR: integr8ly/installation#800 |
grdryn
reviewed
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.jboss.org/browse/AEROGEAR-9674
As we discussed in Google chat, I didn't want to give "view" role to the entire namespace. In that case, users would be able to see pods, deployments etc. and even rsh into pods.
With this change, OpenShift console will work. Users will be able to click on the project
mobile-developer-consoleand go toRoutesand see the URL for MDC route. They will see error messages like "An error occurred connecting to the server. Failed to list services/v1 (status 403)" though. The error messages won't block anything but they're rather annoying.@odra might have a better idea for extracting the MDC url.