Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

feat: integrated docs changed to reflect aerogear-js-sdk API changes #179

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

wojta
Copy link
Contributor

@wojta wojta commented Feb 6, 2019

Motivation

https://issues.jboss.org/browse/AEROGEAR-8502

What

Modified integrated docs to reflect changes made in aerogear-js-sdk from 2.1.0-rc3

Why

Because of changes in aerogear/aerogear-js-sdk#230

How

Only initialization of SDK and small fixes.

Verification Steps

  1. Launch MDC
  2. Go to Mobile Apps >> yourapp
  3. In Mobile Services tab bind all available services - IDM, Sync, Metrics, Push
  4. Check the documentation for Ionic and Cordova in Configuration tab

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

@wojta wojta requested a review from wtrocki February 6, 2019 10:31
Copy link

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! However I'm not sure if the flow merge to master is the right thing.
Packages are released as prerelease so we may hold of with merging

@wei-lee wei-lee merged commit 4a38106 into aerogear:master Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants