Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

refactor: remove app label and use the owner references to show service in Bound list #388

Merged
merged 1 commit into from
Aug 22, 2019
Merged

refactor: remove app label and use the owner references to show service in Bound list #388

merged 1 commit into from
Aug 22, 2019

Conversation

craicoverflow
Copy link

@craicoverflow craicoverflow commented Aug 22, 2019 •
edited

https://issues.jboss.org/browse/AEROGEAR-9779

Follow up to #386.

This change reverts the changes from #386 and uses a different solution.

This change uses the ownerReferences to show Bound services in the correct list.

Verification

  1. Create a new app.
  2. Bind all services.
  3. The services should show in the correct lists (Bound Services or Unbound Services).
  4. Inspect the service CRs. They should no longer have any labels.

@craicoverflow craicoverflow force-pushed the AEROGEAR-9779 branch 3 times, most recently from bd676df to 17fcb54 Compare August 22, 2019 09:37
@craicoverflow craicoverflow marked this pull request as ready for review August 22, 2019 09:41
@ziccardi
Copy link
Member

👀

ziccardi
ziccardi approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@ziccardi ziccardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my cluster. While with the previous version creating a 70 characters long app was causing an error, with this change it works.

Moreover, the change is backward compatible.

@craicoverflow craicoverflow merged commit 68fe5a0 into aerogear:master Aug 22, 2019
@craicoverflow craicoverflow changed the title refactor: compare app label value against app name and UID refactor: remove app label and use the owner references to show service in Bound list Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ziccardi ziccardi ziccardi approved these changes

@wei-lee wei-lee Awaiting requested review from wei-lee

@Boomatang Boomatang Awaiting requested review from Boomatang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craicoverflow @ziccardi