Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

add a screenshot for registering the mobile clients in getting starte… #137

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

wei-lee
Copy link
Contributor

@wei-lee wei-lee commented Jul 2, 2018

…d guide

JIRA: https://issues.jboss.org/browse/AEROGEAR-3510

Add a screenshot of the mobile client view when registering a mobile client.

ping @finp

@johnfriz
Copy link

johnfriz commented Jul 2, 2018

@wei-lee Can you add a screenshot of how the docs look with this image in place. Will make reviewing much quicker.

@wei-lee
Copy link
Contributor Author

wei-lee commented Jul 2, 2018

screen shot 2018-07-02 at 13 14 36

@wei-lee
Copy link
Contributor Author

wei-lee commented Jul 2, 2018

@johnfriz @finp updated now. I can also move it be part of step 4 if you think it's better that way.

@johnfriz
Copy link

johnfriz commented Jul 2, 2018

@wei-lee Looks good overall.

Not sure about the last sentence though "This screen displays a list of mobile services
that you can associate with the Mobile Client and offers to provision any mobile service that is in the service catalog but is not currently provisioned."

What does the "this" refer to at the start of the sentence - is it the project overview screen? If so, then I'm not sure the content is correct. If it's not the overview screen, then we need to clarify what "this" means.

@johnfriz
Copy link

johnfriz commented Jul 2, 2018

@wei-lee - OK, looking at the source of the changes, I see that you did not write/update that sentence. However, I still think we need to change it - should it be a separate ticket or just done in this PR?

@johnfriz
Copy link

johnfriz commented Jul 2, 2018

@wei-lee - It also still bothers me that the Android and iOS icons are still black & white while the Cordova and Xamarin ones are in colour. I know it's not related to this PR, but wondering if we want to fix it for community release? If so, we would need to re-do this screen shot. Thoughts?

@wei-lee wei-lee force-pushed the AG-3510-mobile-client-screenshot branch from d56b3e5 to f5a7c46 Compare July 2, 2018 13:36
@wei-lee
Copy link
Contributor Author

wei-lee commented Jul 2, 2018

@johnfriz I update the wording to replace "This" with "The {mobile-client} view". I think once we have the mobile client section done, we can link to it.

In terms of the icons, they are still white & black in the latest version of the web console. I don't know how much work there will be to update them, I think @jasonmadigan or @sedroche will have a better idea. I don't mind updating the screenshot again if they are updated.

But for now, I'd like to merge this PR and when we have the icons we can update it again.

@wei-lee
Copy link
Contributor Author

wei-lee commented Jul 2, 2018

I created a JIRA to capture the work to update the icons.

@johnfriz
Copy link

johnfriz commented Jul 2, 2018

👍

@wei-lee wei-lee merged commit 8ea64bd into aerogear:master Jul 2, 2018
@wei-lee wei-lee deleted the AG-3510-mobile-client-screenshot branch July 2, 2018 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants