This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
added custom scalar warning #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
reviewed
Aug 30, 2018
| @@ -34,6 +34,8 @@ type Note { | |||
| Save the schema py pressing the `Save Schema` button. Upon saving the {sync-service} will check your schema for errors and compile it to a JSON representation. | |||
| You can download this JSON representation by clicking on `Download Compiled Schema`. This is needed in the client SDKs. | |||
|
|
|||
| NOTE: When defining custom scalars on your schema it is important to assert that the data types are what you are actually expecting. For example if passing a JSON object consisting of String fields, it is important to validate they are actually Strings. | |||
There was a problem hiding this comment.
scalars could have link to graphql docs.
data types are what you are actually expecting. => matching expected type
For example if passing a JSON object consisting of String fields, it is important to validate they are actually Strings. Example gives little context.
This is actually resolver specific (and client). I will skip that part completely and say that Scalar definitions could potentially lead to SQLInjection etc. IMHO first sentence will be enough if we mention why this is needed - SQL injection/GraphQL injection
wtrocki
reviewed
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/AEROGEAR-7717