Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

docs(README): minor corrections (AEROGEAR-9256) #108

Merged

Conversation

damienomurchu
Copy link
Contributor

Motivation

fix minor issues in README

What

fix minor issues in README

Why

fix minor issues in README

How

fix minor issues in README

Verification Steps

Check README & verify changes are ok.

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task

Additional Notes

README.adoc Outdated
| link:./pkg/controller/mobilesecurityservice/configmaps.go[configmaps.go] | Define the ConfigMap resources required for the Mobile Security Service Application and its Database. It will create the mobile-security-service-app` which map the values used in the Environment Variables of both.
| link:./pkg/controller/mobilesecurityservice/deployments.go[deployments.go] | Define the Deployment resource of Mobile Security Service Application. (E.g container and resources definitions)
| link:./pkg/controller/mobilesecurityservice/configmaps.go[configmaps.go] | Define the ConfigMap resources required for the Mobile Security Service Application and its Database. It will create the `mobile-security-service-app` which map the values used in the Environment Variables of both.
| link:./pkg/controller/mobilesecurityservice/deployments.go[deployments.go] | Define the Deployment resource of Mobile Security Service Application, ie container and resources definitions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as eg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite the same actually (https://www.thoughtco.com/when-to-use-common-latin-abbreviations-116688) - have switched back to e.g. :)

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shows fine for me 👍

@damienomurchu damienomurchu merged commit 24e8c19 into aerogear:master May 30, 2019
@damienomurchu damienomurchu deleted the readme-corrections branch May 30, 2019 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants