This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
fix(prometheus) : fix review suggestion which causes mal format issues #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @austincunningham I believe that you made this suggestion. However, it broke the alerts. |
camilamacedo86
requested review from
odra and
danielpassos
and removed request for
danielpassos
odra
approved these changes
Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#151
What
Why
The format with "" was causing issues and not render the alerts.
Verification Steps
See here: https://prometheus-route-middleware-monitoring.apps.london-2f09.openshiftworkshop.com/alerts
Checklist:
Progress
Additional Notes