Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, but in order to test this in CI, Jenkinsfile needs to be added.
See other operators for a reference, e.g. mdc-operator
Also, renaming the
|
Build is failing because this operator requires a separate CR for deploying a DB for some reason.. Also, I'm not sure if we should suddenly add all of the content from |
@psturc @STEPHINRACHEL we decided a while back to not include the vendor folder in this repo. You can see comments about it in thsi pr: #87 Although we have included it for other repos and it's not obvious from the linked pr what the internal discussion was and how we resulted in removing it. |
I don't have a problem with committing the vendor directory; but if it's being done, consider adding the That should drastically reduce the number of files committed. The only thing to think of is that when importing a new package (i.e. one that we haven't used before) from an existing dependency, we'd need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation
https://issues.jboss.org/browse/AEROGEAR-9798
What
Added e2e test for MSS operator
How
Using Operator-SDK's test framework
Verification Steps
Run the following from repository
Checklist:
Progress