Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

test(mobilesecurityservice): add test to package (AEROGEAR-8950) #89

Merged
merged 1 commit into from
May 17, 2019

Conversation

craicoverflow
Copy link

@craicoverflow craicoverflow commented May 17, 2019

Motivation

https://issues.jboss.org/browse/AEROGEAR-8950

What

Added unit tests to cover the mobilesecurityservice package. Reached 73.6% code coverage.

Why

Unit tests ensure that the code is fully tested and work as expected.

How

  1. Referred to Operator SDK documentation
  2. Referred to Operator SDK samples.

Verification Steps

Add the steps required to check this change. Following an example.

  1. Run make test
  2. Do the tests pass?
  3. Confirm that the CircleCI build is passing: https://circleci.com/gh/aerogear/mobile-security-service-operator.

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task
  • TODO

@craicoverflow craicoverflow changed the title test(mobilesecurityservice): add test to package (AEROGEAR-8951) test(mobilesecurityservice): add test to package (AEROGEAR-8950) May 17, 2019
Copy link
Contributor

@damienomurchu damienomurchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified tests pass locally. Approving also as PR can be merged as-is & if anything else is need to satisfy the JIRA it can be added in another PR.

@craicoverflow craicoverflow merged commit 52306f8 into aerogear:master May 17, 2019
@craicoverflow craicoverflow deleted the AEROGEAR-8950 branch May 17, 2019 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants