Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

feat: Add CircleCI configuration #13

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

davidffrench
Copy link
Member

@davidffrench davidffrench commented Jan 30, 2019

Motivation

https://issues.jboss.org/browse/AEROGEAR-8364

What

Adding CircleCI configuration to this repo

Why

Automatically run tests and docker builds on PRs and tags.

How

  • Adding a circleci config
  • Creating the repo in circleci, coveralls and dockerhub. Adding the correct env vars

Verification Steps

Check the CircleCI job run against this PR passes.

Progress

  • Finished task
  • TODO

environment:
POSTGRESQL_PASSWORD: postgres
POSTGRESQL_USER: postgresql
POSTGRESQL_DATABASE: mobile-security-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to not store credentials in the clear

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes there is, they can be stored as environment variables in circleci. I don't believe it will an issue though as it is a temporary database to run integration tests. @darahayes can you confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
Copy link
Member

@austincunningham austincunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, verified the ci is working on this pr

@davidffrench davidffrench merged commit 67c7858 into aerogear:master Jan 30, 2019
@damienomurchu
Copy link
Contributor

Good work @davidffrench - noticed the below warning on the CI build, just fyi:

# -------- WARNING ---------
# Your config does not conform to the schema.
# Violations are listed below:
# 
# ERROR IN CONFIG FILE:
# [#/jobs/build] only 1 subschema matches out of 2
# 1. [#/jobs/build/docker/1] extraneous key [ports] is not permitted
# |   Permitted keys:
# |     - image
# |     - name
# |     - entrypoint
# |     - command
# |     - user
# |     - environment
# |     - aws_auth
# |     - auth
# |   Passed keys:
# |     - image
# |     - ports
# |     - environment

(https://circleci.com/gh/aerogear/mobile-security-service/16#config/containers/0)

@davidffrench
Copy link
Member Author

Thanks @damienomurchu. I will wait until we have integration tests to run in postgres to make sure it is working. Looks like the $DATABASE_URL might need to be specified to satisfy the circleci schema for the port. https://circleci.com/docs/2.0/postgres-config/#example-environment-setup

jhellar pushed a commit to jhellar/mobile-security-service that referenced this pull request Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants