-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
fb69de1
to
6df0de9
Compare
e1262b1
to
44b22bf
Compare
.circleci/config.yml
Outdated
environment: | ||
POSTGRESQL_PASSWORD: postgres | ||
POSTGRESQL_USER: postgresql | ||
POSTGRESQL_DATABASE: mobile-security-service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way to not store credentials in the clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes there is, they can be stored as environment variables in circleci. I don't believe it will an issue though as it is a temporary database to run integration tests. @darahayes can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some info on it here https://circleci.com/docs/2.0/env-vars/
44b22bf
to
4fa89e3
Compare
4fa89e3
to
907821b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, verified the ci is working on this pr
Good work @davidffrench - noticed the below warning on the CI build, just fyi:
(https://circleci.com/gh/aerogear/mobile-security-service/16#config/containers/0) |
Thanks @damienomurchu. I will wait until we have integration tests to run in postgres to make sure it is working. Looks like the $DATABASE_URL might need to be specified to satisfy the circleci schema for the port. https://circleci.com/docs/2.0/postgres-config/#example-environment-setup |
doc(readme) : Review/Changes
Motivation
https://issues.jboss.org/browse/AEROGEAR-8364
What
Adding CircleCI configuration to this repo
Why
Automatically run tests and docker builds on PRs and tags.
How
Verification Steps
Check the CircleCI job run against this PR passes.
Progress