Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

deletes application by Id, #44

Merged
merged 6 commits into from
May 6, 2020

Conversation

AindriuBrennan
Copy link
Contributor

@AindriuBrennan AindriuBrennan commented Apr 24, 2020

Motivation

ISSUES: https://issues.redhat.com/browse/AEROGEAR-10242 and #20
Add the ability to delete an application using the unifiedpush admin-client, I don't think this is working properly but I gave it a stab nontheless

@ziccardi
Copy link
Member

ziccardi commented May 1, 2020

👀

Copy link
Member

@ziccardi ziccardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.
You need to update the nockMock to support app deletion. It currently only support variant deletion.

test/applications/ApplicationsAdmin.test.ts Outdated Show resolved Hide resolved
test/applications/ApplicationsAdmin.test.ts Outdated Show resolved Hide resolved
@AindriuBrennan AindriuBrennan merged commit f9267ca into aerogear:master May 6, 2020
@AindriuBrennan AindriuBrennan deleted the issue-20 branch May 6, 2020 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants