Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Aerogear 10278 - Added secret renew API #77

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Aerogear 10278 - Added secret renew API #77

merged 2 commits into from
Jun 19, 2020

Conversation

ziccardi
Copy link
Member

@ziccardi ziccardi commented Jun 18, 2020

Motivation

https://issues.redhat.com/browse/AEROGEAR-10278

What

Added the renewSecret to the VariantAdmin class

Why

The AdminUI has a feature to renew the secret

Verification Steps

  1. Open the UPS admin UI and create a variant
  2. Take note of the variantid and the application id
  3. Write a small program using this version of the client library and call the new api:
    new UnifiedPushAdminClient('http://localhost:9999').
        variants.renewSecret('appId', 'variant type', 'variant id');
  4. Refresh the AdminUI and verify that the variant secret has changed

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

@github-actions
Copy link

Pull Request Test Coverage Report for Build 139633599

  • 5 of 24 (20.83%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.2%) to 71.765%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/UnifiedPushAdminClient.ts 0 1 0.0%
src/errors/ErrorBuilder.ts 2 6 33.33%
src/errors/InternalError.ts 1 5 20.0%
src/errors/NotFoundError.ts 0 5 0.0%
src/variants/VariantsAdmin.ts 2 7 28.57%
Totals Coverage Status
Change from base Build 123655034: -9.2%
Covered Lines: 103
Relevant Lines: 128

💛 - Coveralls

@ziccardi ziccardi force-pushed the AEROGEAR-10278 branch 2 times, most recently from 9b1aabe to 2663c0a Compare June 18, 2020 14:01
Copy link
Contributor

@AindriuBrennan AindriuBrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works!

@ziccardi ziccardi merged commit 9d3fbb3 into master Jun 19, 2020
@ziccardi ziccardi deleted the AEROGEAR-10278 branch June 19, 2020 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants