Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Aerogear 10238 #54

Merged
merged 8 commits into from
Jun 3, 2020
Merged

Aerogear 10238 #54

merged 8 commits into from
Jun 3, 2020

Conversation

AindriuBrennan
Copy link
Contributor

@AindriuBrennan AindriuBrennan commented May 8, 2020

Motivation

https://issues.redhat.com/browse/AEROGEAR-10238

What

Implement a delete button that when clicked, it would open up a dialog that requires the user to input the name of the app to deleted for confirmation.
when the delete app button is clicked the app is deleted, the dialog is closed and the application list is refreshed.

Comparison view the dialogs

Old delete app view
old Delete

New Delete app view
Delete app small

Butons right aligned and showing hover
buttons showing hover

@AindriuBrennan AindriuBrennan marked this pull request as ready for review May 11, 2020 15:31
src/application/wizard/DeleteApplicationPage.tsx Outdated Show resolved Hide resolved
src/application/wizard/DeleteApplicationPage.tsx Outdated Show resolved Hide resolved
src/common/Modal.tsx Outdated Show resolved Hide resolved
src/landing/ApplicationList.tsx Outdated Show resolved Hide resolved
@ziccardi
Copy link
Member

@Aindriunannerb in the screenshot, I see that the dialog is very large, much larger than its content. We can maybe make it a bit smaller and/or make the content fill the entire width.
Moreover the Delete Application title, should be the Dialog title, so that it is aligned with the X button that closes the dialog.

Copy link
Member

@ziccardi ziccardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aindriunannerb
The old implementation of the list was like this
old impl

The new one is like this
new impl

Can we make the new one look similar to the old one?
Alternatively, can we horizontally align the button on the right and center them vertically?

To avoid polluting the page would be nice to have them appear only when overing over the application as in the previous implementation

@ziccardi
Copy link
Member

@Aindriunannerb Both EDIT and DELETE button opens the DELETE dialog. Is that expected?

@AindriuBrennan
Copy link
Contributor Author

AindriuBrennan commented May 20, 2020

@Aindriunannerb Both EDIT and DELETE button opens the DELETE dialog. Is that expected?

@ziccardi This is resolved in another PR when the Edit functionality is implemented correctly.

@ziccardi ziccardi merged commit 701a1b4 into aerogear:PF4 Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants