This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Aerogear 10237 #55
Merged
Aerogear 10237 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created Update App name View, WIP rename function not working Renames app correctly Aligns buttons to the right, Buttons hidden unless hovered over.
AindriuBrennan
force-pushed
the
AEROGEAR-10237
branch
from
0951d62
to
f6ecad5
Compare
ziccardi
suggested changes
Jun 3, 2020
ziccardi
suggested changes
Jun 3, 2020
There was a problem hiding this comment.
When I try to rename an application, the dialog opens giving me the change to edit the application name. However the proposed name is not editable, but I have to rewrite it from scratch.
Moreover, if I try to rename another application, it always propose me the last name I wrote.
ziccardi
suggested changes
Jun 5, 2020
…dateApplicationPage component
… TextInput of deleteAppPage dialog
AindriuBrennan
force-pushed
the
AEROGEAR-10237
branch
from
3a199d8
to
03b6790
Compare
ziccardi
approved these changes
Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://issues.redhat.com/browse/AEROGEAR-10237
PR for creating the view for Renaming an Application on the UnifiedPush Server.
This is the dialog for the old Admin UI
This is the Rename dialog for the new Admin UI