This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
feat: Rename & Delete Variant Buttons added #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the VariantItem Components and will appear when a user mouses over the component, this behavior is the same as how the Rename and Delete buttons work for the Application.
|
Merged with some small feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These buttons are attached to the VariantItem Components and will appear when a user mouses over the
component, this behavior is the same as how the Rename and Delete
buttons work for the Application.
Motivation
https://issues.redhat.com/browse/AEROGEAR-10213
What
This emulates how the "edit" and "delete" buttons functioned on the old Admin UI,
The old Admin UI Edit dialog
The new Rename Variant dialog
The old Delete Variant dialog
The new Delete Variant dialog
Checklist: