adds a test-runner that sends notifications to all apps #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove dependency put business logic in src folder sends a notification to each app, separated by 1000 ms Refactor sender module catches error in the app level gets the list of applications gets bearer token from UPS with existing client updates .gitignore
|
Let's add a README file in the folder, |
matzew
reviewed
Jan 27, 2017
| * @returns {Promise} An empty promise if the notification was sent. | ||
| */ | ||
| static sendNotificationToApp(message, app, options) { | ||
| console.log(`Sending message to "${app.name}" {${app.id}}`) |
There was a problem hiding this comment.
change the id to pushApplicationID
matzew
reviewed
Jan 27, 2017
|
|
||
| const settings = { | ||
| url: BASE_URL, | ||
| applicationId: app.id, |
There was a problem hiding this comment.
this needs to be pushApplicationID too, instead of id
Use right property
matzew
reviewed
Jan 27, 2017
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "author": "Jose Miguel Gallas Olmedo", | ||
| "license": "MIT", |
There was a problem hiding this comment.
Apache license!
also, not sure about the author tag... author is always a topic... that's hot discussed in the community. SCM tools do show all the authors of the file.
Perhaps we do AeroGear team
There was a problem hiding this comment.
OK, I wasn't sure so I left the default options.
|
OK I also noticed that the DELAY constant was not being used, so fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves this ticket: https://issues.jboss.org/browse/AGPUSH-2003
Adds a test-runner, written in nodeJS, to the current test suite. This test runner gets all applications from one user and send 1 notification to all of them with the single alias "TEST_TOKEN" that is the one mock-data-loader creates for all fake devices.
This test runner uses both community libraries: https://github.com/bucharest-gold/unifiedpush-admin-client (for retrieving the apps) and https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/ (for sending the notifications).