Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind data to auto-populate bind form #18

Merged
merged 1 commit into from
May 10, 2018
Merged

Conversation

sedroche
Copy link
Contributor

@sedroche sedroche commented May 8, 2018

Ticket: https://issues.jboss.org/browse/AEROGEAR-2413

Adding new property on metadata that will be used to auto-populate binding params form.

Setting a type of path will retrieve the value from the resource.
Setting a type of default will set that value

 '{"name": "CLIENT_ID", "value": "metadata.name", "type": "path"}'
 '{"name": "CLIENT_TYPE", "value": "public", "type": "default"}'

Verification

Use this UI branch -> aerogear-attic/origin-web-console#38

Client binding

custom-client-auto

Client Id should be filled.

Copy link

@dimitraz dimitraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally 👍

apb.yml Outdated
@@ -17,7 +17,9 @@ plans:
- name: default
description: This default plan deploys custom-runtime-connector-apb
free: True
metadata: {}
metadata:
MobileClient_bind_parameters_data:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might look more consistent to make the resource kind all lowercase, just my opinion though. wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that makes sense. I'll add that in. Cheers.

Copy link

@dimitraz dimitraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the Client ID is correctly pre-filled 👍

@sedroche sedroche merged commit 2d428d0 into master May 10, 2018
@sedroche sedroche deleted the add-bind-param-data branch May 10, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants