Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEROGEAR-2233 Custom realm name should be used for original KeyCloak service #54

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Conversation

vchepeli
Copy link
Contributor

@vchepeli vchepeli commented Mar 1, 2018

Describe what this PR does and why we need it:
AEROGEAR-2233

Changes proposed in this pull request
When SHARED_REALM is defined:

  • Realm name should be created with SHARED_REALM name

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes AEROGEAR-2233

@vchepeli
Copy link
Contributor Author

vchepeli commented Mar 1, 2018

ping @maleck13, @philbrookes, @JameelB

Copy link
Contributor

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks reasonable. I will give it a try

@maleck13
Copy link
Contributor

maleck13 commented Mar 1, 2018

Test:

  • create no realm
  • create with realm
  • create shared service with realm

@maleck13
Copy link
Contributor

maleck13 commented Mar 1, 2018

Test worked as expected so I think we just need to get the checks to pass then good to merge

@JameelB
Copy link
Contributor

JameelB commented Mar 1, 2018

@vchepeli Looks good to me too. You might have to regenerate the dockerfile?

@JameelB
Copy link
Contributor

JameelB commented Mar 2, 2018

@maleck13 @vchepeli Tested locally.

Verified the following test cases:

  • Successfully provisioned a shared keycloak with specified realm
  • Successfully provisioned a shared keycloak with no realm specified. (Defaulted to the current namespace)
  • Successfully provisioned a linked keycloak service with a specified realm
  • Successfully provisioned a linked keycloak service with no realm specified (Defaulted to the current namespace).

@vchepeli vchepeli merged commit 722b31a into aerogearcatalog:master Mar 2, 2018
@vchepeli vchepeli deleted the t_AEROGEAR-2233 branch March 2, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants