Add bind param data for autofill params #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedroche
requested review from
philbrookes and
dimitraz
and removed request for
philbrookes
sedroche
force-pushed
the
add-binding-param-data
branch
from
1a847a5
to
39b4b6c
Compare
dimitraz
approved these changes
May 9, 2018
|
@sedroche Is that value there the service Id? Can we change that bind param description to something like |
JameelB
approved these changes
May 9, 2018
JameelB
reviewed
May 9, 2018
| @@ -19,7 +19,13 @@ plans: | |||
| - name: default | |||
| description: Deploy keycloak | |||
| free: True | |||
| metadata: {} | |||
| metadata: | |||
| mobileclient_bind_parameters_data: | |||
There was a problem hiding this comment.
Can we delete this line here
Line 62 in 39b4b6c
There was a problem hiding this comment.
That is still needed for bindings that are not created through our custom UI. This only takes effect through our integrations UI.
|
@sedroche Yeah something along those lines since the value there is not the service name anymore. 👍 |
sedroche
force-pushed
the
add-binding-param-data
branch
from
39b4b6c
to
be8b38c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://issues.jboss.org/browse/AEROGEAR-2413
Adding new property on metadata that will be used to auto-populate binding params form.
Setting a type of
pathwill retrieve the value from the resource.Setting a type of
defaultwill set that valueVerification
Use this UI branch -> aerogear-attic/origin-web-console#38
Client binding
Client Id should be filled and keycloak client type of
publicshould be selected.Service binding
Service Id should be filled and keycloak client type of
bearershould be selected.