Add recreate strategy to postgres #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wei-lee, @darahayes Can you double check it solve the problem before I send for the others APBs? cc/ @grdryn |
|
Checking now 👀 |
wei-lee
reviewed
Mar 13, 2019
| spec_strategy_type: 'Recreate' | ||
| spec_strategy_active_deadline_seconds: 21600 | ||
| spec_strategy_recreate_params: | ||
| timeoutSeconds: 600 |
There was a problem hiding this comment.
can we move these values to be parameters so that it can be overridden
wei-lee
approved these changes
Mar 13, 2019
|
I've just verified that it works. Once we address the feedback, I think this is good to merge! |
|
@wei-lee, @darahayes Done! |
wei-lee
approved these changes
Mar 13, 2019
psturc
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: AEROGEAR-8778