Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sensor coordinates table #125

Merged
merged 4 commits into from
May 31, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented May 30, 2023

Contents (#125)

Enhancements

  • Remove default sensor coordinates

Testing

  • Add missing methods to dummy serial port
  • Update sensor coordinates in documentation and tests

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Patch coverage: 59.30% and project coverage change: -0.28 ⚠️

Comparison is base (cf3b26f) 60.87% compared to head (1a2d373) 60.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   60.87%   60.59%   -0.28%     
==========================================
  Files          15       15              
  Lines        1122     1175      +53     
==========================================
+ Hits          683      712      +29     
- Misses        439      463      +24     
Impacted Files Coverage Δ
data_gateway/exceptions.py 100.00% <ø> (ø)
data_gateway/packet_reader.py 45.84% <34.88%> (-1.04%) ⬇️
data_gateway/data_gateway.py 90.00% <68.42%> (+1.11%) ⬆️
data_gateway/persistence.py 94.20% <87.50%> (-0.50%) ⬇️
data_gateway/cli.py 91.57% <100.00%> (ø)
data_gateway/configuration.py 94.78% <100.00%> (+0.56%) ⬆️
data_gateway/dummy_serial/dummy_serial.py 91.89% <100.00%> (-2.40%) ⬇️
data_gateway/serial_port.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cortadocodes cortadocodes self-assigned this May 31, 2023
@cortadocodes cortadocodes merged commit 18801c3 into main May 31, 2023
3 checks passed
@cortadocodes cortadocodes deleted the feature/add-support-for-sensor-coordinates-table branch May 31, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants