Use separate thread to read packets from serial port #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortadocodes
force-pushed
the
fix/read-from-serial-port-in-separate-thread
branch
from
67662ae
to
8be20a7
Compare
cortadocodes
changed the title
…test TST: Fix info packets test
'origin/feature/add-ability-to-provide-command-routines' into fix/read-from-serial-port-in-separate-thread
cortadocodes
requested review from
time-trader and
thclark
and removed request for
time-trader and
thclark
thclark
requested changes
Dec 20, 2021
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| setup( | |||
| name="data_gateway", | |||
| version="0.8.0", | |||
| version="0.8.1", | |||
There was a problem hiding this comment.
Multi threading feels like a new feature 😂
There was a problem hiding this comment.
Yeah I guess, I'm doing it to fix a bug though :P I think I'll probably change it to a minor version increase.
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separate serial port reading from packet parsing, processing, and persistence to avoid data loss due to serial port overflow.
Contents (#15)
Enhancements
serial.threadingto bulk read packets from serial port in a separate threadRefactoring
PacketReader._parse_payloadtoPacketReader.parse_payloadTesting