Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure keys in configuration are always strings; fix configuration serialisation #8

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Ensure keys in configuration are always strings; fix configuration serialisation #8

merged 4 commits into from
Dec 9, 2021

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Dec 8, 2021 •
edited
Loading

Contents (#8)

Fixes

  • Ensure keys in Configuration are always strings so its instances are directly JSON-compatible
  • Convert configurations to dictionaries before using as metadata to avoid JSON serialisation error

Testing

  • Fix deliberate exception raising in cloud upload tests

@cortadocodes cortadocodes linked an issue Dec 8, 2021 that may be closed by this pull request
Integer keys in the configuration file #3
Closed
5 tasks
@cortadocodes cortadocodes self-assigned this Dec 8, 2021
@cortadocodes cortadocodes linked an issue Dec 8, 2021 that may be closed by this pull request
TypeError while persisting to cloud #4
Closed
@cortadocodes cortadocodes changed the title Ensure keys in configuration are always strings Ensure keys in configuration are always strings; fix configuration serialisation Dec 8, 2021
@cortadocodes cortadocodes added the bug Something isn't working label Dec 8, 2021
@cortadocodes cortadocodes merged commit 9ffb555 into main Dec 9, 2021
@cortadocodes cortadocodes deleted the fix/handles-keys branch December 9, 2021 15:12
@time-trader time-trader mentioned this pull request Dec 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-trader time-trader Awaiting requested review from time-trader

Assignees

@cortadocodes cortadocodes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError while persisting to cloud Integer keys in the configuration file
1 participant
@cortadocodes