Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Improve geometry file handling #3

Merged
merged 13 commits into from
Feb 22, 2023
Merged

Feature: Improve geometry file handling #3

merged 13 commits into from
Feb 22, 2023

Conversation

time-trader
Copy link
Contributor

@time-trader time-trader commented Feb 22, 2023 •
edited
Loading

Description

Use Dataset filtered by file name instead of metadata labels.

Breaking changes

Input schema is changed: "airfoil_label" is changed to "airfoil_geometry_filename"

Contents (#3)

New features

  • Use file path instead of label to fetch geom file.
  • Specify geometry as dictionary in the input

Enhancements

  • Silent mode
  • Use manifest and dataset filter
  • Introduce aerofoil geometry schema
  • Raise NotImplementedError

Refactoring

  • Code clean-up

Testing

  • Update deployment test
  • Update tests to a new schema
  • Test new feature

@time-trader time-trader marked this pull request as ready for review February 22, 2023 14:14
cortadocodes
cortadocodes requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@cortadocodes cortadocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Can I just check that I'm understanding the usage correctly - you provide a manifest containing lots of datafiles but then only get the service to analyse one of them?

app.py Outdated Show resolved Hide resolved
twine.json Outdated Show resolved Hide resolved
xfoil_module/routines.py Outdated Show resolved Hide resolved
xfoil_module/routines.py Outdated Show resolved Hide resolved
xfoil_module/routines.py Outdated Show resolved Hide resolved
@time-trader
Copy link
Contributor Author

Looks good overall. Can I just check that I'm understanding the usage correctly - you provide a manifest containing lots of datafiles but then only get the service to analyse one of them?

Yes.

@cortadocodes
Copy link
Member

Why not just provide one file? Is it because the details of batching haven't been decided on yet?

@time-trader time-trader merged commit b3f865b into main Feb 22, 2023
@time-trader time-trader deleted the feature/improve-geometry-file-handling branch February 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortadocodes cortadocodes cortadocodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@time-trader @cortadocodes