Optimisation computeDigest() in key.go?

[csimplestring]

I notice that the key.go: every time computing a digest for a key, it has to allocate a new slice. This will stress GC. In aerospike java client source code, I notice that thread-local buffer technique is used to improve this. But in Golang, there is no equivalent technique. I think why not to use a singleton buffer to hold data when computing key digest, instead of allocating a new slice many times?

[khaf]

Thank you for your suggestion. A simple singleton buffer cannot be used in concurrent applications. We can use a queue to cache many buffers, but then we will have to pay the cost of synchronization (and memory to keep all those buffers around indefinitely).

I still agree that this part of code is a hot spot and should be further optimized, and a variation of your suggestion could potentially reduce the load on GC.

Please note that the client code is not micro-optimized yet. We'll begin to work on optimizations and micro-benchmarking after we have released all the planned functionality. This being said, it still performs reasonably well compared to Java client.

We welcome any suggestions to make the client better and easier to work with.

[khaf]

As of beta release, Hash objects are pooled now. There's also no heap allocations anymore..