Add JS wrappers for C client add/remove seed functions

as_cluster_add_seed/as_cluster_remove_seed where added in C client v4.1.6 for dynamic seed changes after cluster has been initialized. This just adds wrappers for these functions to the JS Client interface.
aerospike · May 22, 2017 · ff146b9 · ff146b9
1 parent f0896d9
commit ff146b9
Show file tree

Hide file tree

Showing 5 changed files with 72 additions and 0 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -112,6 +112,7 @@ Client.setCallbackHandler = function (callbackHandler) {
  * const policy = { timeout: 1000 }
  *
  * Aerospike.connect((error, client) => {
+ *   if (err) throw err
  *   var llist = client.LargeList(key, 'ldtBinName', policy);
  *   llist.add('abc', (error) => {
  *     client.close()
@@ -122,6 +123,36 @@ Client.prototype.LargeList = function (key, binName, policy, createModule) {
   return new LargeList(this, key, binName, policy, createModule)
 }
 
+/**
+ * @function Client#addSeedHost
+ *
+ * @summary Adds a seed host to the cluster.
+ *
+ * @param {String} hostname - Hostname/IP address of the new seed host
+ * @param {Number} [port=3000] - Port number; defaults to {@link Config#port} or 3000.
+ *
+ * @since v2.6.0
+ */
+Client.prototype.addSeedHost = function (hostname, port) {
+  port = port || this.config.port
+  this.as_client.addSeedHost(hostname, port)
+}
+
+/**
+ * @function Client#removeSeedHost
+ *
+ * @summary Removes a seed host from the cluster.
+ *
+ * @param {String} hostname - Hostname/IP address of the seed host
+ * @param {Number} [port=3000] - Port number; defaults to {@link Config#port} or 3000.
+ *
+ * @since v2.6.0
+ */
+Client.prototype.removeSeedHost = function (hostname, port) {
+  port = port || this.config.port
+  this.as_client.removeSeedHost(hostname, port)
+}
+
 /**
  * @function Client#batchExists
  *

diff --git a/lib/config.js b/lib/config.js
@@ -120,6 +120,8 @@ function Config (config) {
    */
   if (typeof config.port === 'number') {
     this.port = config.port
+  } else {
+    this.port = 3000
   }
 
   /**

diff --git a/src/include/client.h b/src/include/client.h
@@ -84,6 +84,7 @@ class AerospikeClient : public ObjectWrap {
 		 *  CLIENT OPERATIONS
 		 **********************************************************************/
 
+		static NAN_METHOD(AddSeedHost);
 		static NAN_METHOD(ApplyAsync);
 		static NAN_METHOD(BatchExists);
 		static NAN_METHOD(BatchGet);
@@ -107,6 +108,7 @@ class AerospikeClient : public ObjectWrap {
 		static NAN_METHOD(Register);
 		static NAN_METHOD(RegisterWait);
 		static NAN_METHOD(RemoveAsync);
+		static NAN_METHOD(RemoveSeedHost);
 		static NAN_METHOD(ScanBackground);
 		static NAN_METHOD(ScanAsync);
 		static NAN_METHOD(SelectAsync);

diff --git a/src/main/client.cc b/src/main/client.cc
@@ -138,6 +138,7 @@ void AerospikeClient::Init()
 	// object using an internal field.
 	tpl->InstanceTemplate()->SetInternalFieldCount(1);
 
+	Nan::SetPrototypeMethod(tpl, "addSeedHost", AddSeedHost);
 	Nan::SetPrototypeMethod(tpl, "applyAsync", ApplyAsync);
 	Nan::SetPrototypeMethod(tpl, "batchExists", BatchExists);
 	Nan::SetPrototypeMethod(tpl, "batchGet", BatchGet);
@@ -161,6 +162,7 @@ void AerospikeClient::Init()
 	Nan::SetPrototypeMethod(tpl, "queryBackground", QueryBackground);
 	Nan::SetPrototypeMethod(tpl, "queryForeach", QueryForeach);
 	Nan::SetPrototypeMethod(tpl, "removeAsync", RemoveAsync);
+	Nan::SetPrototypeMethod(tpl, "removeSeedHost", RemoveSeedHost);
 	Nan::SetPrototypeMethod(tpl, "scanAsync", ScanAsync);
 	Nan::SetPrototypeMethod(tpl, "scanBackground", ScanBackground);
 	Nan::SetPrototypeMethod(tpl, "selectAsync", SelectAsync);

diff --git a/src/main/client/cluster.cc b/src/main/client/cluster.cc
@@ -21,6 +21,7 @@
 extern "C" {
     #include <aerospike/aerospike.h>
     #include <aerospike/as_async_proto.h>
+    #include <aerospike/as_cluster.h>
 }
 
 using namespace v8;
@@ -95,3 +96,37 @@ NAN_METHOD(AerospikeClient::HasPendingAsyncCommands)
 
 	info.GetReturnValue().Set(Nan::New(pending));
 }
+
+/**
+ * Adds a seed host to the cluster.
+ */
+NAN_METHOD(AerospikeClient::AddSeedHost)
+{
+	Nan::HandleScope scope;
+	AerospikeClient * client = ObjectWrap::Unwrap<AerospikeClient>(info.This());
+
+	TYPE_CHECK_REQ(info[0], IsString, "hostname must be a string");
+	TYPE_CHECK_REQ(info[1], IsNumber, "port must be a number");
+
+	String::Utf8Value hostname(info[0]->ToString());
+	uint16_t port = (uint16_t) info[1]->ToInteger()->Value();
+
+	as_cluster_add_seed(client->as->cluster, *hostname, NULL, port);
+}
+
+/**
+ * Removes a seed host from the cluster.
+ */
+NAN_METHOD(AerospikeClient::RemoveSeedHost)
+{
+	Nan::HandleScope scope;
+	AerospikeClient * client = ObjectWrap::Unwrap<AerospikeClient>(info.This());
+
+	TYPE_CHECK_REQ(info[0], IsString, "hostname must be a string");
+	TYPE_CHECK_REQ(info[1], IsNumber, "port must be a number");
+
+	String::Utf8Value hostname(info[0]->ToString());
+	uint16_t port = (uint16_t) info[1]->ToInteger()->Value();
+
+	as_cluster_remove_seed(client->as->cluster, *hostname, port);
+}