Updated CDT op policy: Add list/map NO_FAIL/PARTIAL flags, new map write flags #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhecking
commented
Jul 12, 2018
jhecking
commented
- Add new list policy write flags NO_FAIL & PARTIAL
- Add new map policy write flags, incl. NO_FAIL & PARTIAL to replace write mode
* Support NO_FAIL & PARTIAL flags for list ops * Add new write flags to map policy, replacing write mode * Support NO_FAIL & PARTIAL flags for map ops
The insert-bounded flag for list operations is supported on servers pre-4.3. But pre-4.3, insertions that result in a bounds violation, are treated as a no-op and do not return an error. Starting with v4.3, such bounds violations return an error, unless the no-fail flag is set as well.
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 96.13% 96.35% +0.21%
==========================================
Files 43 43
Lines 1397 1399 +2
==========================================
+ Hits 1343 1348 +5
+ Misses 54 51 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.