Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the implementation of scan_apply to match the python client's d… #100

Merged
merged 1 commit into from Mar 11, 2016
Merged

Conversation

hawka
Copy link
Contributor

@hawka hawka commented Feb 4, 2016

…ocumentation, wherein providing additional args to a UDF is optional.

Ref: Documentation for Client.scan_apply

In the current implementation, passing no py_args into the Client.scan_apply() function results in a segfault, which is no bueno.

If the ability to pass no py_args is not the desired behavior, then I believe that the documentation should be changed, and line 103 modified to also ensure that py_args is present and return a useful error:

if (!(namespace_p) || !(py_set) || !(py_module) || !(py_function) || !(py_args)) {
    as_error_update(&err, AEROSPIKE_ERR_PARAM, "Parameter should not be null");
    goto CLEANUP;
}

…ocumentation, wherein providing additional args to a UDF is optional.
@jboone100 jboone100 self-assigned this Mar 11, 2016
@jboone100
Copy link
Contributor

Thanks @hawka ! This will be included in the 2.0.2 release.

@jboone100 jboone100 merged commit c401f13 into aerospike:master Mar 11, 2016
mlicheng pushed a commit to mlicheng/aerospike-client-python that referenced this pull request Mar 23, 2017
CLIENT-597 obey an explicit lua user_path
rpandian-spike pushed a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants