[CLIENT-2887] Fix aerospike.Client() segfaulting when it fails to connect

[juliannguyen4]

How seg fault occurs

When aerospike.Client(config) is called, where config has a host / port that fails to connect:

1. tp_new to create a new aerospike.Client object in Python. This presumably creates a new reference to the aerospike.Client object
2. AerospikeClient_Type_Init() (tp_init) initializes theaerospike.Client object in Python, populates a C client config struct using the Python client's config dictionary, then creates a new C client using self->as = aerospike_new(&config);. Fail to connect, so destroy C client using aerospike_destroy(self->as);
3. In Python, no reference to the aerospike.Client object exists anymore, so AerospikeClient_Type_Dealloc() (tp_dealloc) is called
4. AerospikeClient_Type_Dealloc() calls aerospike_destroy() again on the same C client, causing a double free (seg fault)

Fix

In AerospikeClient_Type_Init(), if C client fails to connect, don't destroy it and let AerospikeClient_Type_Dealloc() handle it later.

Implications of this fix

aerospike.client(config) code must be changed to avoid a memory leak

AerospikeClient_New() is the Python client C code for aerospike.client(config). This is the main way to create a client, rather than aerospike.Client(config). aerospike.client(config) calls in this order:

• AerospikeClient_Type.tp_new() to create the aerospike.Client object
• AerospikeClient_Type.tp_init() to initialize the aerospike.Client object.
• If tp_init() fails (i.e fails to connect), AerospikeClient_Type.tp_free() destroys the aerospike.Client object.

After this PR's changes, when the client fails to connect with aerospike.client(config), AerospikeClient_New() must find another way to destroy the C client since tp_init no longer does it. tp_dealloc destroys both the C client and Python client, so we replace tp_free() with that.

Valgrind

Dev: https://github.com/aerospike/aerospike-client-python/actions/runs/8914308860/job/24481631213
This branch: https://github.com/aerospike/aerospike-client-python/actions/runs/8913166351/job/24478118908

No new memory errors and there are less memory leaks in this branch

Build wheels all passes except for noise: https://github.com/aerospike/aerospike-client-python/actions/runs/9008696941

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (b80723d) to head (50f6d3a).
Report is 3 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #608   +/-   ##
=======================================
  Coverage   81.35%   81.36%           
=======================================
  Files         100      100           
  Lines       15355    15355           
=======================================
+ Hits        12492    12493    +1     
+ Misses       2863     2862    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[justinlee-aerospike]

changes look good