Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2904] Add support for macOS 13 #609

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 26, 2024

Extra changes:

  • Fix bug where macOS stage tests always use server RC

Tests pass on macOS 13: https://github.com/aerospike/aerospike-client-python/actions/runs/8884125090/job/24393025635

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (dc46dc7) to head (f3e8cd3).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #609   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         100      100           
  Lines       15355    15355           
=======================================
  Hits        12492    12492           
  Misses       2863     2863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review April 29, 2024 21:35
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine

@juliannguyen4 juliannguyen4 merged commit 1134f94 into dev Apr 30, 2024
56 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2904-support-macos-13 branch April 30, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants