Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor benchmark improvements #71

Merged
merged 1 commit into from Aug 1, 2018
Merged

Minor benchmark improvements #71

merged 1 commit into from Aug 1, 2018

Conversation

jhecking
Copy link
Contributor

@jhecking jhecking commented Aug 1, 2018

  • Use actual elapsed time to calculate TPS instead of assuming exact, 1 second intervals
  • Terminate benchmark on interrupt (CTRL-C)
  • Print total TPS for entire benchmark duration at end

@jhecking
Improve benchmarks
f1665bf 
* Use actual elapsed time to calculate TPS instead of assuming exact, 1 second intervals
* Terminate benchmark on interrupt (CTRL-C)
* Print total TPS for entire benchmark duration at end
@jhecking jhecking added this to the v2.8 milestone Aug 1, 2018
@jhecking jhecking self-assigned this Aug 1, 2018
@codecov-io
Copy link

codecov-io commented Aug 1, 2018 •
edited

Codecov Report

Merging #71 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   94.91%   94.93%   +0.02%     
==========================================
  Files         153      153              
  Lines        9895     9897       +2     
==========================================
+ Hits         9392     9396       +4     
+ Misses        503      501       -2
Impacted Files Coverage Δ
lib/aerospike/cluster.rb 93.65% <0%> (+0.03%) ⬆️
lib/aerospike/query/stream_command.rb 91.83% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb9880...f1665bf. Read the comment docs.

@jhecking jhecking merged commit c76e3f0 into master Aug 1, 2018
@jhecking jhecking deleted the f-improve-benchmark branch August 1, 2018 13:06
jhecking added a commit that referenced this pull request Aug 1, 2018
@jhecking
Merge branch 'master' into check-conn-alive
45a27c9 
* master:
  Improve benchmarks (#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhecking jhecking

Labels
enhancement
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhecking @codecov-io