Om82 - dashboard fixes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
below fixes are included - added job-name in missing queries - fixed hard-coded job-name with query - corrected some Timeseries as "Range" instead of "Instant" - modified all the Graph (old) panels as "Timeseries" panel - this brings all panels to the 9.3.x version - fixed variables in some dashboard with right variable filters -
incorporated review comments - added job_name on template variables where required - made order of template variable same across all dashboards in below order -- Data-Source -- Job-Name (Prometheus) -- Cluster -- Node -- Namespace -- Set correct wrong check-in on latencies.json where job dashboard was accidentally saved.
fix duplicate panel-id: same panel-id is assigned to another panel, hence any fixes are not reflecting correctly. manually modified the panel-id of 3 panels - new panel-id are max-of-current-panel-id + 1
fixed linter issues in jobs.view
fixed set dashboard query to use proper regex ~ to support multi-selection
replaced DS_EXPRESSION with __expr__ without this Unique Data calculation is not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved - all dashboards to Gafana 9.3.x
corrected sequence of all dashboard variable in order like “Datasource”, “Job”, “Cluster”, “Node”, “Set”
fixed duplicate-panel-id in namespace view dashboard which is not-showing correct information
bug-fixes:
fixed time-series as “range” wherever it is configured as “instant”
added job-name in queries wherever they are missing & required
removed and replaced hard-coded job-name with variable $job_name