Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epoll_event isn't packed on all architectures #3

Closed
grooverdan opened this issue May 22, 2018 · 3 comments
Closed

epoll_event isn't packed on all architectures #3

grooverdan opened this issue May 22, 2018 · 3 comments

Comments

@grooverdan
Copy link

grooverdan commented May 22, 2018

ubuntu-18.04 ppc64le - git master @ c302133

epoll_event isn't packed on all architectures so replicating the structure isn't portable and indeed causes runtime ppc64le problems.

The structure is redefined here:
https://github.com/aerospike/aerospike-server/blob/master/cf/include/socket.h#L156..L160

For portability the data.ptr union element could be used where the existing code rather than recreating the structure data structure element.

The structure is defined in the standard:
https://linux.die.net/man/2/epoll_wait

brihh added a commit to brihh/aerospike-server that referenced this issue Jun 28, 2018
brihh added a commit to brihh/aerospike-server that referenced this issue Oct 24, 2018
changed to use the standard provided union of auxiliary data as per the epoll_ctl man page.

aerospike#3
narqo added a commit to narqo/aerospike-server that referenced this issue Jan 12, 2020
@grooverdan
Copy link
Author

🐌

@kportertx
Copy link
Contributor

This will be addressed in 6.2 to support ARM. This ticket is now effectively a duplicate of #19.

@kportertx
Copy link
Contributor

6.2 has been released with ARM support: https://download.aerospike.com/download/server/notes.html#6.2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants