tools-2788 Reset s3API state on shutdown. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdogmcsteezy
reviewed
Dec 6, 2023
Comment on lines
+82
to
+83
| // NOTE: logLevel should be reset to match | ||
| // whatever S3_DEFAULT_LOG_LEVEL is if it changes |
There was a problem hiding this comment.
Is this a TODO or a note? It does not look like you are doing what it is recommending
There was a problem hiding this comment.
It's a reminder to update this if the default changes in the future. I can't use the default that asbackup configs use because it is a different type
jdogmcsteezy
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clears out state in between s3 backups.