Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONNECTOR-435 Update versions in Dockerfile #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CONNECTOR-435 Update versions in Dockerfile #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cdfabf
Update Dockerfile
mcoberly2 Jul 14, 2023
9526dc8
CONNECTOR-435 Update Dockerfile
mcoberly2 Jul 14, 2023
bb9b242
Update Dockerfile
mcoberly2 Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,19 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
ARG TRINO_VERSION=391
ARG TRINO_VERSION=403

FROM trinodb/trino:${TRINO_VERSION}

ARG CONNECTOR_VERSION=4.3.0-391
ARG CONNECTOR_VERSION=4.4.1-403

USER root:root
RUN \
apt-get update && \
apt-get -y -q install unzip ca-certificates wget uuid-runtime gettext && \
export BASE_VERSION=$(echo $CONNECTOR_VERSION | cut -d '-' -f 1) && \
# CONNECTOR-435 Solution
# Alternative: wget -q -O /tmp/aerospike.zip "https://download.aerospike.com/artifacts/enterprise/aerospike-trino/$BASE_VERSION/aerospike-trino-$CONNECTOR_VERSION.zip" && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoberly2 why not replacing the URL?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reugn Which url you're referring to? The one on 27 seems to be evolved version of the url on 26.

wget -q -O /tmp/aerospike.zip "https://www.aerospike.com/artifacts/enterprise/aerospike-trino/$BASE_VERSION/aerospike-trino-$CONNECTOR_VERSION.zip" && \
unzip -q /tmp/aerospike.zip -d /tmp && \
mv /tmp/trino-aerospike-$CONNECTOR_VERSION /usr/lib/trino/plugin/aerospike && \
Expand Down