Windmill + load objects with bridges #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es into the world from config file
|
Feature is implemented but there might be better ways to structure code in ign_assets, @pariaspe check it out and we talk. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #145 +/- ##
=====================================
Coverage 4.93% 4.93%
=====================================
Files 93 93
Lines 4681 4681
Branches 513 513
=====================================
Hits 231 231
Misses 4250 4250
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pariaspe
requested changes
Jan 30, 2023
as2_aerial_platforms/as2_platform_ign_gazebo/launch/ign_gazebo_launch.py
Outdated
Show resolved
Hide resolved
as2_simulation_assets/as2_ign_gazebo_assets/launch/launch_simulation.py
Outdated
Show resolved
Hide resolved
as2_simulation_assets/as2_ign_gazebo_assets/models/windmill/windmill.sdf.jinja
Outdated
Show resolved
Hide resolved
as2_simulation_assets/as2_ign_gazebo_assets/src/ign_assets/model.py
Outdated
Show resolved
Hide resolved
as2_simulation_assets/as2_ign_gazebo_assets/worlds/windmill_world.sdf
Outdated
Show resolved
Hide resolved
|
@pariaspe is this ready for merge? |
pariaspe
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added working windmill model, added feature to load object with bridges into the world from config file.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points