Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes use Aerostack2 Node Create Timer method, not create wall timer #212

Conversation

RPS98
Copy link
Contributor

@RPS98 RPS98 commented Apr 11, 2023


Basic Info

Info Please fill out this column
Issue(s) this addresses #211
ROS2 version tested on Humble
Aerial platform tested on Ignition

Description of contribution in a few bullet points

  • Change create wall timer to as2 create timer, so the timer use the /clock time instead of the wall timer.

Description of documentation updates required from your changes

  • Development guide should have this as2 features.

@RPS98 RPS98 added the bug Something isn't working label Apr 11, 2023
@RPS98 RPS98 requested a review from miferco97 April 11, 2023 10:41
@RPS98 RPS98 self-assigned this Apr 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #212 (d74bf32) into main (e142f85) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head d74bf32 differs from pull request most recent head 79c40af. Consider uploading reports for the commit 79c40af to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##            main    #212      +/-   ##
========================================
- Coverage   3.13%   3.06%   -0.07%     
========================================
  Files         99      96       -3     
  Lines       5135    5121      -14     
  Branches     451     466      +15     
========================================
- Hits         161     157       -4     
+ Misses      4836    4810      -26     
- Partials     138     154      +16     
Flag Coverage Δ
unittests 3.06% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../as2_platform_crazyflie/src/crazyflie_platform.cpp 0.00% <0.00%> (ø)
...s/as2_platform_dji_osdk/include/dji_subscriber.hpp 0.00% <0.00%> (ø)
...as2_platform_dji_osdk/src/dji_matrice_platform.cpp 0.00% <ø> (ø)
...latforms/as2_platform_tello/src/tello_platform.cpp 0.00% <0.00%> (ø)
...lude/as2_behavior/__impl/behavior_server__impl.hpp 0.00% <0.00%> (ø)
as2_core/src/aerial_platform.cpp 0.00% <0.00%> (ø)
as2_motion_controller/src/controller_manager.cpp 0.00% <0.00%> (ø)

... and 45 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@miferco97 miferco97 merged commit bbf7abb into main Apr 11, 2023
@pariaspe pariaspe deleted the 211-nodes-should-use-aerostack2-node-create-timer-method-not-create-wall-timer branch April 11, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes should use Aerostack2 Node Create Timer method, not create wall timer
3 participants