Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use tf2_geometry_msgs library when needed #317

Merged
merged 2 commits into from Aug 22, 2023
Merged

Only use tf2_geometry_msgs library when needed #317

merged 2 commits into from Aug 22, 2023

Conversation

pariaspe
Copy link
Member

Basic Info

Info Please fill out this column
Issue(s) this addresses #316
ROS2 version tested on Humble
Aerial platform tested on -

Description of contribution in a few bullet points

  • Add dependency to as2_core package.xml
  • Removed include from as2_platform_dji_osdk, as2_behaviors_motion, as2_realsense_interface, as2_motion_controller, as2_state_estimator and as2_motion_reference_handlers
  • Using .hpp instead of .h library following deprecation warning suggestion

@pariaspe pariaspe linked an issue Aug 21, 2023 that may be closed by this pull request
[as2_core] Add tf2_geometry_msgs to package.xml #316
Closed
@miferco97
Copy link
Member

miferco97 commented Aug 21, 2023 •
edited

@pariaspe I wouldn't change the .hpp now, the CI will crash then

@pariaspe pariaspe requested review from miferco97 and removed request for miferco97 August 21, 2023 16:31
miferco97
miferco97 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@miferco97 miferco97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if removing the dependencies can make the other packages not to compile properly but let's see.

@miferco97 miferco97 merged commit ece064c into main Aug 22, 2023
2 checks passed
@pariaspe pariaspe deleted the 316-tf2_geometry_msgs-dep branch August 22, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miferco97 miferco97 miferco97 approved these changes

@RPS98 RPS98 Awaiting requested review from RPS98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[as2_core] Add tf2_geometry_msgs to package.xml
2 participants
@pariaspe @miferco97