Client authentication #500
Conversation
- Add /user/ request for projects - Scaffold for legacy sessions
* Formatting * Keycloak icon URL
|
@KrisDavie note that the SemGrep issues weren't introduced in this PR |
There was a problem hiding this comment.
Changes make sense to me, didn't really look into detail at the implementation of things since I am not that familiar with how code is structured in this project.
There are 2 things that might be useful to add to the authentication as well:
- Persisting authentication status. When you now refresh the page, authentication status is lost. Not really an issue since most users don't manually refresh there page, but would be nice if you could remain logged in after leaving the page.
- Ability to log out. For now you can just refresh the page to do this, but a dedicated button would be nicer.
These changes are not necessarily needed in this PR. If they seem interesting enough, they can be added to the TODOs aswell
|
@kverstae Thanks for having a look at this! Your review is very helpful and insightful.
I have some code ready to do this in a follow up PR.
Indeed of course. That will be a TODO item. (#508)
Indeed I'd like to avoid any further PR rot. |
Introduce a `SCOPE_SERVER_URL` environment variable which may be used at build time to change the default API server URL. If this Env Var is not set then default to localhost:8000 in development and scope.aertslab.org for production.
| @@ -75,7 +76,7 @@ export function* uploadFile(endpoint: string, project: string, file: File) { | |||
| } | |||
|
|
|||
| export function* uploadRequest(action: T.UploadRequest) { | |||
| const url = new URL(API_PREFIX + 'project/dataset'); | |||
| const url = new URL(SERVER_URL + API_PREFIX + 'project/dataset'); | |||
There was a problem hiding this comment.
Could this not use the API_URL from api.ts?
Integrates login to the client.
Also updates to react-routerv6, changes are as lazy as possible (so break a lot of features)